lkml.org 
[lkml]   [2023]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] drivers: rtc: max31335: initial commit
    On 31/10/2023 11:23:49+0000, Miclaus, Antoniu wrote:
    > > > + if (status != MAX31335_STATUS1_DEFAULT)
    > > > + dev_err_probe(&client->dev, -EINVAL,
    > > > + "Unable to read from device.\n");
    > > > +
    > >
    > > That is misleading. The device returned an unexpected status.
    > > I don't know if this really reflects a problem, but it is not
    > > "Unable to read from device".
    > >
    >
    > Since the device lacks an ID register, I found this as a suitable
    > replacement for checking that the communication with the
    > device actually works before the probe function finishes
    > successfully.
    >
    > I will be more specific in the dev_err_probe message in the
    > upcoming patch version.
    >

    What if this is a transient bus error and the device is actually present
    and working?
    don't like this kind of check, they are not usually useful.

    --
    Alexandre Belloni, co-owner and COO, Bootlin
    Embedded Linux and Kernel engineering
    https://bootlin.com

    \
     
     \ /
      Last update: 2023-10-31 14:55    [W:6.699 / U:0.596 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site