Messages in this thread | | | From | Javier Martinez Canillas <> | Subject | Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable | Date | Tue, 31 Oct 2023 11:11:24 +0100 |
| |
Geert Uytterhoeven <geert@linux-m68k.org> writes:
Hello Geert,
> Hi Javier, > > On Fri, Oct 27, 2023 at 11:33 AM Javier Martinez Canillas > <javierm@redhat.com> wrote: >> Jocelyn Falempe <jfalempe@redhat.com> writes: >> > On 21/10/2023 00:52, Javier Martinez Canillas wrote: >> >> Avoid a possible uninitialized use of the crtc_state variable in function >> >> ssd132x_primary_plane_atomic_check() and avoid the following Smatch warn: >> >> >> >> drivers/gpu/drm/solomon/ssd130x.c:921 ssd132x_primary_plane_atomic_check() >> >> error: uninitialized symbol 'crtc_state'. >> > >> > That looks trivial, so you can add: >> > >> > Acked-by: Jocelyn Falempe <jfalempe@redhat.com> >> > >> >> Pushed to drm-misc (drm-misc-next). Thanks! > > Looks like you introduced an unintended > > (cherry picked from commit 9e4db199e66d427c50458f4d72734cc4f0b92948) > > ? >
No, that's intended. It's added by the `dim cherry-pick` command, since I had to cherry-pick to drm-misc-next-fixes the commit that was already in the drm-misc-next branch.
You will find that message in many drm commits, i.e:
$ git log --oneline --grep="(cherry picked from commit" drivers/gpu/drm/ | wc -l 1708
> Gr{oetje,eeting}s, >
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |