Messages in this thread | | | Date | Mon, 30 Oct 2023 11:43:27 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 5/7] dt-bindings: trivial-devices: Add IOT2050 Arduino SPI connector |
| |
On Fri, Oct 27, 2023 at 03:34:36PM +0200, Jan Kiszka wrote: > From: Jan Kiszka <jan.kiszka@siemens.com> > > On the Siemens IOT2050 devices, the SPI controller wired to the Arduino > connector is normally driven by userspace. Introduce a binding for use > by spidev.
What's spidev? Not a h/w device...
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 430a814f64a5..01b9f36afcd5 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -349,6 +349,8 @@ properties: > - silabs,si3210 > # Relative Humidity and Temperature Sensors > - silabs,si7020 > + # Siemens IOT2050: SPI interface on Arduino connector > + - siemens,iot2050-arduino-spi
How is this specific to your board? Presumably, an 'Arduino connector' is a somewhat standard interface, right? If every board with an Arduino connector adds a compatible, this doesn't scale.
A connector is what you should be describing, but I imagine it is not just SPI. Here's some past discussions[1][2] on the need for connector bindings.
Rob
[1] https://lore.kernel.org/all/20220421094421.288672-1-michael@walle.cc/ [2] https://lore.kernel.org/all/CAL_JsqK2DKPbaFvUPSU2E7oh1_pryrRXPMg8OASmK722jmznwA@mail.gmail.com/
| |