Messages in this thread | | | Date | Mon, 30 Oct 2023 14:29:54 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] nvme-tcp: Fix a memory leak |
| |
On Sun, Oct 29, 2023 at 10:22:57PM +0100, Christophe JAILLET wrote: > if (ctype != TLS_RECORD_TYPE_DATA) { > pr_err("queue %d: unhandled TLS record %d\n", > nvme_tcp_queue_id(queue), ctype); > - return -ENOTCONN; > + ret = -ENOTCONN; > + goto free_icresp; > } > } > ret = -EINVAL;
I'd slightly prefer the code to be consistent how it assigns to err, and use the style where it is assigned in the main path as with the -EINVAL for the next checks.
Except for that this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |