Messages in this thread | | | Date | Mon, 30 Oct 2023 13:07:11 +0100 | From | Jiri Pirko <> | Subject | Re: [PATCH net] net: page_pool: add missing free_percpu when page_pool_init fail |
| |
Mon, Oct 30, 2023 at 10:12:56AM CET, shaojijie@huawei.com wrote: >From: Jian Shen <shenjian15@huawei.com> > >When ptr_ring_init() returns failure in page_pool_init(), free_percpu() >is not called to free pool->recycle_stats, which may cause memory >leak.
Would be nice to see the use of imperative mood in the patch description too, not only patch subject. Nevertheless, fix looks fine:
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
| |