Messages in this thread | | | Date | Tue, 31 Oct 2023 01:31:11 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: phy: broadcom: Wire suspend/resume for BCM54612E |
| |
On Mon, Oct 30, 2023 at 11:54:45PM +0100, Marco von Rosenberg wrote: > On some devices, the bootloader suspends the PHY before booting the OS. > Not having a resume callback wired up is a problem in such situations > since it is then never resumed.
Hi Marco
This description seems odd to me. I'm guessing here:
Are we talking about a device which as been suspended? The PHY has been left running because there is no suspend callback? Something then triggers a resume. The bootloader then suspends the active PHY? Linux then boots, detects its a resume, so does not touch the hardware because there is no resume callback? The suspended PHY is then useless.
Adding suspend/resume calls makes sense, i just don't follow the commit message reasoning.
Andrew
| |