Messages in this thread | | | From | Neal Gompa <> | Date | Mon, 30 Oct 2023 20:00:16 -0400 | Subject | Re: [RESEND PATCH] soc: apple: mailbox: Add explicit include of platform_device.h |
| |
On Mon, Oct 30, 2023 at 10:27 AM Rob Herring <robh@kernel.org> wrote: > > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other and pull in various other headers. In > preparation to fix this, adjust the includes for what is actually needed. > > platform_device.h is implicitly included by of_platform.h, but that's going > to be removed. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Note this was added in the merge window and missed the last round. > > Arnd, Can you apply this directly. > > --- > drivers/soc/apple/mailbox.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/apple/mailbox.c b/drivers/soc/apple/mailbox.c > index 0cbd172f435e..780199bf351e 100644 > --- a/drivers/soc/apple/mailbox.c > +++ b/drivers/soc/apple/mailbox.c > @@ -26,6 +26,7 @@ > #include <linux/module.h> > #include <linux/of.h> > #include <linux/of_platform.h> > +#include <linux/platform_device.h> > #include <linux/pm_runtime.h> > #include <linux/spinlock.h> > #include <linux/types.h> > -- > 2.42.0 > >
Pretty obvious patch.
Reviewed-by: Neal Gompa <neal@gompa.dev>
-- 真実はいつも一つ!/ Always, there's only one truth!
| |