Messages in this thread | | | Date | Mon, 30 Oct 2023 15:20:05 -0700 | From | Frederik Deweerdt <> | Subject | Re: [PATCH] [RFC] Add missing NULL check in `tls_strp_check_queue_ok` |
| |
On Mon, Oct 30, 2023 at 03:05:12PM -0700, Jakub Kicinski wrote: > On Mon, 30 Oct 2023 14:57:29 -0700 Frederik Deweerdt wrote: > > We see `tls_strp_check_queue_ok` running into a NULL deref when > > evaluating `TCP_SKB_CB(skb)->seq`. > > > > This commit attempts to address the issue by exiting the loop if > > skb->next is NULL, and has proven stable under load. > > > > That said i don't understand the code enough to convince myself that > > the NULL check is indeed required, and i would be happy gather data if > > that's useful. > > Hm. Can you share the decoded stack trace?
We could only have screen captures from the management console. I've attached the image to this email.
Frederik [unhandled content-type:image/png] | |