Messages in this thread | | | Date | Mon, 30 Oct 2023 14:53:06 -0700 | Subject | Re: [PATCH v4 3/5] r8169: Coalesce mac ocp write and modify for 8168H start to reduce spinlocks | From | Jacob Keller <> |
| |
On 10/29/2023 4:04 AM, Mirsad Goran Todorovac wrote: > Repeated calls to r8168_mac_ocp_write() and r8168_mac_ocp_modify() in > the startup of 8168H involve implicit spin_lock_irqsave() and spin_unlock_irqrestore() > on each invocation. > > Coalesced with the corresponding helpers, r8168_mac_ocp_write_seq() and > r8168_mac_ocp_modify_seq() with a sinqle lock/unlock, these calls reduce overall > lock contention. > > Fixes: ef712ede3541d ("r8169: add helper r8168_mac_ocp_modify") > Fixes: 6e1d0b8988188 ("r8169:add support for RTL8168H and RTL8107E") > Cc: Heiner Kallweit <hkallweit1@gmail.com> > Cc: Marco Elver <elver@google.com> > Cc: nic_swsd@realtek.com > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Link: https://lore.kernel.org/lkml/20231028005153.2180411-1-mirsad.todorovac@alu.unizg.hr/ > Link: https://lore.kernel.org/lkml/20231028110459.2644926-1-mirsad.todorovac@alu.unizg.hr/ > Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> > ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
| |