| Date | Tue, 3 Oct 2023 23:02:40 +0800 | From | Kent Gibson <> | Subject | Re: [PATCH 04/36] gpio: cdev: use pinctrl_gpio_can_use_line_new() |
| |
On Tue, Oct 03, 2023 at 04:50:42PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Use the improved variant of pinctrl_gpio_can_use_line() which takes a > pointer to the gpio_chip and a controller-relative offset. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > drivers/gpio/gpiolib-cdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c > index 31fc71a612c2..54ee075410db 100644 > --- a/drivers/gpio/gpiolib-cdev.c > +++ b/drivers/gpio/gpiolib-cdev.c > @@ -2287,8 +2287,7 @@ static void gpio_desc_to_lineinfo(struct gpio_desc *desc, > * FIXME: find a non-racy way to retrieve this information. Maybe a > * lock common to both frameworks? > */ > - ok_for_pinctrl = > - pinctrl_gpio_can_use_line(gc->base + info->offset); > + ok_for_pinctrl = pinctrl_gpio_can_use_line_new(gc, info->offset); >
_new?? In what sense?
I agree with the change in principle, just not comfortable with the naming.
Cheers, Kent.
|