Messages in this thread | | | Date | Tue, 3 Oct 2023 22:55:50 +0800 | Subject | Re: [PATCH v4] sched/rt: move back to RT_GROUP_SCHED and rename it child | From | Yajun Deng <> |
| |
On 2023/10/3 17:51, Ingo Molnar wrote: > * Yajun Deng <yajun.deng@linux.dev> wrote: > >> The member back in struct sched_rt_entity only related to RT_GROUP_SCHED, >> it should not place out of RT_GROUP_SCHED, move back to RT_GROUP_SCHED >> and rename it child. >> >> Init child when parent isn't NULL in init_tg_rt_entry(). >> >> Introduce for_each_sched_rt_entity_reverse() to iterate rt_se from >> top to down. >> >> Signed-off-by: Yajun Deng <yajun.deng@linux.dev> >> Reported-by: kernel test robot <oliver.sang@intel.com> >> Closes: https://lore.kernel.org/oe-lkp/202308031034.4369b15b-oliver.sang@intel.com > Yeah, so I agree with these changes, but could you please split up this > patch into 3 separate patches: > > sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block > sched/rt: Rename sched_rt_entity::back to sched_rt_entity::child > sched/rt: Introduce for_each_sched_rt_entity_reverse() & use it
Okay, This patch makes sense, it saves a few bytes. But Peter seems to have a different opinion.
@Peter, I think I split up this patch into 2 separate patches:
sched/rt: Introduce for_each_sched_rt_entity_back() & use it
sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block
Comments, please...
> > Thanks, > > Ingo
| |