lkml.org 
[lkml]   [2023]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 16/29] jfs: move jfs_xattr_handlers to .rodata
    From
    On 9/30/23 12:00AM, Wedson Almeida Filho wrote:
    > From: Wedson Almeida Filho <walmeida@microsoft.com>
    >
    > This makes it harder for accidental or malicious changes to
    > jfs_xattr_handlers at runtime.
    >
    > Cc: Dave Kleikamp <shaggy@kernel.org>
    > Cc: jfs-discussion@lists.sourceforge.net
    > Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>

    Reviewed-by: Dave Kleikamp <dave.kleikamp@oracle.com>

    > ---
    > fs/jfs/jfs_xattr.h | 2 +-
    > fs/jfs/xattr.c | 2 +-
    > 2 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/fs/jfs/jfs_xattr.h b/fs/jfs/jfs_xattr.h
    > index 0d33816d251d..ec67d8554d2c 100644
    > --- a/fs/jfs/jfs_xattr.h
    > +++ b/fs/jfs/jfs_xattr.h
    > @@ -46,7 +46,7 @@ extern int __jfs_setxattr(tid_t, struct inode *, const char *, const void *,
    > extern ssize_t __jfs_getxattr(struct inode *, const char *, void *, size_t);
    > extern ssize_t jfs_listxattr(struct dentry *, char *, size_t);
    >
    > -extern const struct xattr_handler *jfs_xattr_handlers[];
    > +extern const struct xattr_handler * const jfs_xattr_handlers[];
    >
    > #ifdef CONFIG_JFS_SECURITY
    > extern int jfs_init_security(tid_t, struct inode *, struct inode *,
    > diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c
    > index 931e50018f88..001c900a2b4d 100644
    > --- a/fs/jfs/xattr.c
    > +++ b/fs/jfs/xattr.c
    > @@ -985,7 +985,7 @@ static const struct xattr_handler jfs_trusted_xattr_handler = {
    > .set = jfs_xattr_set,
    > };
    >
    > -const struct xattr_handler *jfs_xattr_handlers[] = {
    > +const struct xattr_handler * const jfs_xattr_handlers[] = {
    > &jfs_os2_xattr_handler,
    > &jfs_user_xattr_handler,
    > &jfs_security_xattr_handler,

    \
     
     \ /
      Last update: 2023-10-03 16:56    [W:2.143 / U:0.780 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site