Messages in this thread | | | Date | Tue, 3 Oct 2023 19:32:46 +0530 | Subject | Re: [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in USB node | From | Praveenkumar I <> |
| |
On 9/30/2023 10:56 PM, Dmitry Baryshkov wrote: > On 29/09/2023 16:31, Praveenkumar I wrote: >> >> >> On 9/29/2023 6:44 PM, Konrad Dybcio wrote: >>> On 29.09.2023 10:42, Praveenkumar I wrote: >>>> Add UNIPHY node in USB to support Super-speed. As the SS PHY has >>>> pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag. >>>> >>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >>>> --- >>> Patches 6 and 7 should be swapped, otherwise you may get no >>> USB with this commit. Incremental patches must not break >>> functionality, unless it is truly inevitable. >> Understood. Will swap the 6 and 7 patches in the update. > > But just swapping the patches will not work, the patch for the board > file will break compilation. I think you have to squash them. I think swapping will work as the PHY node in the base dtsi added separately in patch 3. If compilation fails, will squash them.
- Praveenkumar > >> >> -- >> Thanks, >> Praveenkumar >>> >>> Konrad >> >
| |