Messages in this thread | | | Date | Tue, 3 Oct 2023 06:42:13 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH v6 net-next 0/5] net: dsa: hsr: Enable HSR HW offloading for KSZ9477 |
| |
On Tue, 3 Oct 2023 14:51:06 +0200 Lukasz Majewski wrote: > I've just noticed that there is a WARNING: > https://patchwork.kernel.org/project/netdevbpf/patch/20230922133108.2090612-6-lukma@denx.de/ > > but then on the newest kernel checkpatch.pl is silent: > ./scripts/checkpatch.pl > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch total: 0 > errors, 0 warnings, 0 checks, 277 lines checked > > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch has no > obvious style problems and is ready for submission. > > Does the checkpatch for patchwork differs in any way from mainline?
We run:
checkpatch with --strict --max-line-length=80
https://github.com/kuba-moo/nipa/blob/master/tests/patch/checkpatch/checkpatch.sh
The "multiple new lines" warning on patch 2 looks legit, no?
| |