Messages in this thread | | | Date | Tue, 3 Oct 2023 16:10:13 +0300 (EEST) | From | Ilpo Järvinen <> | Subject | Re: [UPDATE][PATCH] platform/x86/intel-uncore-freq: Conditionally create attribute for read frequency |
| |
On Mon, 2 Oct 2023, Srinivas Pandruvada wrote:
> When the current uncore frequency can't be read, don't create attribute > "current_freq_khz" as any read will fail later. Some user space > applications like turbostat fail to continue with the failure. So, check > error during attribute creation. > > Fixes: 8a54e2253e4c ("platform/x86/intel-uncore-freq: Uncore frequency control via TPMI")
Hi,
Thanks for the update but that commit id looks bogus, or where the value is used w/o error check?
-- i.
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > --- > update > - Added Fixes tag > > .../x86/intel/uncore-frequency/uncore-frequency-common.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c > index 1152deaa0078..33ab207493e3 100644 > --- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c > +++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c > @@ -176,7 +176,7 @@ show_uncore_data(initial_max_freq_khz); > > static int create_attr_group(struct uncore_data *data, char *name) > { > - int ret, index = 0; > + int ret, freq, index = 0; > > init_attribute_rw(max_freq_khz); > init_attribute_rw(min_freq_khz); > @@ -197,7 +197,11 @@ static int create_attr_group(struct uncore_data *data, char *name) > data->uncore_attrs[index++] = &data->min_freq_khz_dev_attr.attr; > data->uncore_attrs[index++] = &data->initial_min_freq_khz_dev_attr.attr; > data->uncore_attrs[index++] = &data->initial_max_freq_khz_dev_attr.attr; > - data->uncore_attrs[index++] = &data->current_freq_khz_dev_attr.attr; > + > + ret = uncore_read_freq(data, &freq); > + if (!ret) > + data->uncore_attrs[index++] = &data->current_freq_khz_dev_attr.attr; > + > data->uncore_attrs[index] = NULL; > > data->uncore_attr_group.name = name; >
| |