Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Tue, 3 Oct 2023 14:44:00 +0200 | Subject | Re: [PATCH v4 04/11] gpiolib: provide gpio_device_find_by_label() |
| |
On Mon, Oct 2, 2023 at 11:53 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > On Mon, Oct 2, 2023 at 11:44 AM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Wed, Sep 27, 2023 at 04:29:24PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > > > By far the most common way of looking up GPIO devices is using their > > > label. Provide a helpers for that to avoid every user implementing their > > > own matching function. > > > > ... > > > > > +struct gpio_device *gpio_device_find_by_label(const char *label) > > > +{ > > > + return gpio_device_find((void *)label, gpio_chip_match_by_label); > > > +} > > > > Are we expecting that data referenced by the first parameter to the > > gpio_device_find() can be altered? If not, why not using const void * > > there and here as well? > > > > I guess it's a good idea. > > Bart
Scratch that. When we know that we're passing a label, it's fine to have it const but almost treewide, various matching functions take "void *data" as argument. I'll leave it this way.
Bart
| |