lkml.org 
[lkml]   [2023]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/6] arm64: dts: ti: k3-am62a7-sk: Drop i2c-1 to 100Khz


On 28-Sep-23 14:54, Jai Luthra wrote:
> The TLV320AIC3106 audio codec is interfaced on the i2c-1 bus. With the
> default rate of 400Khz the i2c register writes fail to sync:
>
> [ 36.026387] tlv320aic3x 1-001b: Unable to sync registers 0x16-0x16. -110
> [ 38.101130] omap_i2c 20010000.i2c: controller timed out
>
> Dropping the rate to 100Khz fixes the issue.
>
> Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
> Signed-off-by: Jai Luthra <j-luthra@ti.com>

Since the codec wouldn't have worked with the 400KHz, the initial DT
configuration is wrong, which makes this patch a fix, and should be
indicated as such.

With the Fixes tag added,

Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>

Regards
Aradhya

> ---
> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index c689d3da2def..866b2725f775 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -261,7 +261,7 @@ &main_i2c1 {
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&main_i2c1_pins_default>;
> - clock-frequency = <400000>;
> + clock-frequency = <100000>;
>
> exp1: gpio@22 {
> compatible = "ti,tca6424";
>

\
 
 \ /
  Last update: 2023-10-03 07:24    [W:0.115 / U:2.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site