Messages in this thread | | | Subject | Re: [PATCH v5 11/18] x86/sgx: store unreclaimable pages in LRU lists | Date | Tue, 03 Oct 2023 00:15:32 -0500 | From | "Haitao Huang" <> |
| |
On Thu, 28 Sep 2023 04:41:33 -0500, Huang, Kai <kai.huang@intel.com> wrote:
> >> --- a/arch/x86/kernel/cpu/sgx/encl.c >> +++ b/arch/x86/kernel/cpu/sgx/encl.c >> @@ -746,6 +746,7 @@ void sgx_encl_release(struct kref *ref) >> xa_destroy(&encl->page_array); >> >> if (!encl->secs_child_cnt && encl->secs.epc_page) { >> + sgx_drop_epc_page(encl->secs.epc_page); >> sgx_encl_free_epc_page(encl->secs.epc_page); >> encl->secs.epc_page = NULL; >> } > > The "record" of SECS/VA pages should be done together with this. I see > no > reason why the "record" and "drop" are separated into different patches.
"record" of SECS/VA pages are done in this patch. Before nothing done in "record" for them because no tracking LRU lists for them. Now they are tracked.
Thanks Haitao
| |