lkml.org 
[lkml]   [2023]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 1/4] firmware: arm_scmi: Add polling support for completion in smc
    On Mon, Sep 11, 2023 at 12:43:56PM -0700, Nikunj Kela wrote:
    > Currently, the return from the smc call assumes the completion of
    > the scmi request. However this may not be true in virtual platforms
    > that are using hvc doorbell.
    >

    Hmm, it is expectation from SMCCC for the fast calls. Is you HVC FID
    not a fast call. AFAIK, only TOS use yielding calls. Are you using them
    here ? If not, this must complete when the SMC/HVC returns. We added
    support for platforms indicating the same via interrupt.

    I would like to avoid adding this build config. Why does it require polling ?
    Broken firmware ? I would add a compatible for that. Or if the qcom always
    wants to do this way, just make it specific to the qcom compatible.

    I would avoid a config flag as it needs to be always enabled for single
    image and affects other platforms as well. So please drop this change.
    If this is absolutely needed, just add additional property which DT
    maintainers may not like as it is more like a policy or just make it
    compatible specific.

    --
    Regards,
    Sudeep

    \
     
     \ /
      Last update: 2023-10-03 12:33    [W:3.580 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site