Messages in this thread | | | Date | Wed, 4 Oct 2023 00:14:09 +0300 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next v3 2/8] net: dsa: vsc73xx: convert to PHYLINK |
| |
Hi Paweł,
On Tue, Oct 03, 2023 at 10:45:45PM +0200, Paweł Dembicki wrote: > I plan to make rgmii delays configurable from the device tree. Should I? > a. switch to phy_interface_is_rgmii in the current patch? > b. add another patch in this series? > c. wait with change to phy_interface_is_rgmii for patch with rgmii > delays configuration?
If you want to configure the RGMII delays in the vsc73xx MAC, you should look at the "rx-internal-delay-ps" and "tx-internal-delay-ps" properties in the MAC OF node, rather than at the phy-mode. The phy-mode is for the internal delays from the PHY.
In any case, you should accept any phy_interface_is_rgmii() regardless of whether internal delays are configurable in the MAC. And yes, parsing those MAC OF properties should be a separate change.
If the series exceeds 15 patches, I would consider splitting it per topic and submitting separate series (link management would be one, tag_8021q/bridging/VLAN would be another). If they don't conflict and can be applied independently, you could also send the 2 series simultaneously.
| |