lkml.org 
[lkml]   [2023]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 24/28] platform/x86: asus-wmi: Change ASUS_WMI_BRN_DOWN code from 0x20 to 0x2e
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    [ Upstream commit f37cc2fc277b371fc491890afb7d8a26e36bb3a1 ]

    Older Asus laptops change the backlight level themselves and then send
    WMI events with different codes for different backlight levels.

    The asus-wmi.c code maps the entire range of codes reported on
    brightness down keypresses to an internal ASUS_WMI_BRN_DOWN code:

    define NOTIFY_BRNUP_MIN 0x11
    define NOTIFY_BRNUP_MAX 0x1f
    define NOTIFY_BRNDOWN_MIN 0x20
    define NOTIFY_BRNDOWN_MAX 0x2e

    if (code >= NOTIFY_BRNUP_MIN && code <= NOTIFY_BRNUP_MAX)
    code = ASUS_WMI_BRN_UP;
    else if (code >= NOTIFY_BRNDOWN_MIN && code <= NOTIFY_BRNDOWN_MAX)
    code = ASUS_WMI_BRN_DOWN;

    Before this commit all the NOTIFY_BRNDOWN_MIN - NOTIFY_BRNDOWN_MAX
    aka 0x20 - 0x2e events were mapped to 0x20.

    This mapping is causing issues on new laptop models which actually
    send 0x2b events for printscreen presses and 0x2c events for
    capslock presses, which get translated into spurious brightness-down
    presses.

    The plan is disable the 0x11-0x2e special mapping on laptops
    where asus-wmi does not register a backlight-device to avoid
    the spurious brightness-down keypresses. New laptops always send
    0x2e for brightness-down presses, change the special internal
    ASUS_WMI_BRN_DOWN value from 0x20 to 0x2e to match this in
    preparation for fixing the spurious brightness-down presses.

    This change does not have any functional impact since all
    of 0x20 - 0x2e is mapped to ASUS_WMI_BRN_DOWN first and only
    then checked against the keymap code and the new 0x2e
    value is still in the 0x20 - 0x2e range.

    Reported-by: James John <me@donjajo.com>
    Closes: https://lore.kernel.org/platform-driver-x86/a2c441fe-457e-44cf-a146-0ecd86b037cf@donjajo.com/
    Closes: https://bbs.archlinux.org/viewtopic.php?pid=2123716
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20231017090725.38163-2-hdegoede@redhat.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/x86/asus-wmi.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/platform/x86/asus-wmi.h b/drivers/platform/x86/asus-wmi.h
    index b302415bf1d95..49f2b8f8ad3eb 100644
    --- a/drivers/platform/x86/asus-wmi.h
    +++ b/drivers/platform/x86/asus-wmi.h
    @@ -18,7 +18,7 @@
    #include <linux/i8042.h>

    #define ASUS_WMI_KEY_IGNORE (-1)
    -#define ASUS_WMI_BRN_DOWN 0x20
    +#define ASUS_WMI_BRN_DOWN 0x2e
    #define ASUS_WMI_BRN_UP 0x2f

    struct module;
    --
    2.42.0
    \
     
     \ /
      Last update: 2023-10-30 00:05    [W:4.512 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site