Messages in this thread | | | From | Dmitry Baryshkov <> | Date | Sun, 29 Oct 2023 18:39:30 +0200 | Subject | Re: [PATCH v2 2/2] drm/msm/gem: Add metadata |
| |
On Sun, 29 Oct 2023 at 17:07, Rob Clark <robdclark@gmail.com> wrote: > > From: Rob Clark <robdclark@chromium.org> > > The EXT_external_objects extension is a bit awkward as it doesn't pass > explicit modifiers, leaving the importer to guess with incomplete > information. In the case of vk (turnip) exporting and gl (freedreno) > importing, the "OPTIMAL_TILING_EXT" layout depends on VkImageCreateInfo > flags (among other things), which the importer does not know. Which > unfortunately leaves us with the need for a metadata back-channel. > > The contents of the metadata are defined by userspace. The > EXT_external_objects extension is only required to work between > compatible versions of gl and vk drivers, as defined by device and > driver UUIDs. > > v2: add missing metadata kfree > > Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> --- > drivers/gpu/drm/msm/msm_drv.c | 57 ++++++++++++++++++++++++++++++++++- > drivers/gpu/drm/msm/msm_gem.c | 1 + > drivers/gpu/drm/msm/msm_gem.h | 4 +++ > include/uapi/drm/msm_drm.h | 2 ++ > 4 files changed, 63 insertions(+), 1 deletion(-)
-- With best wishes Dmitry
| |