Messages in this thread | | | Date | Wed, 25 Oct 2023 07:14:08 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] net: tls: Fix possible NULL-pointer dereference in tls_decrypt_device() and tls_decrypt_sw() |
| |
On Wed, 25 Oct 2023 12:27:05 +0200 Sabrina Dubroca wrote: > > My bad. I only checked &msg->msg_iter's address in tls_decrypt_sw and found > > it was wrong. Do I need to make a new patch to fix the harmless bogus > > pointer? > > I don't think that's necessary, but maybe it would avoid people trying > to "fix" this code in the future. Jakub, WDYT?
No strong feelings, but personally I find checks for conditions which cannot happen decrease the readability. Maybe a comment is better?
| |