lkml.org 
[lkml]   [2023]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Patch v4 01/11] dt-bindings: media: s5p-mfc: Add mfcv12 variant
From
On 25/10/2023 12:22, Aakarsh Jain wrote:
> Add Tesla FSD MFC(MFC v12) compatible.
>
> Cc: linux-fsd@tesla.com
> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> ---

No changelog and your cover letter does not explain what happened here.
Specifically, why did you decide to ignore received tag.

> .../bindings/media/samsung,s5p-mfc.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> index 084b44582a43..c30eb309f670 100644
> --- a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> +++ b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> @@ -24,6 +24,7 @@ properties:
> - samsung,mfc-v7 # Exynos5420
> - samsung,mfc-v8 # Exynos5800
> - samsung,mfc-v10 # Exynos7880
> + - tesla,fsd-mfc # Tesla FSD
> - items:
> - enum:
> - samsung,exynos3250-mfc # Exynos3250
> @@ -165,6 +166,21 @@ allOf:
> minItems: 1
> maxItems: 2
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - tesla,fsd-mfc
> + then:
> + properties:
> + clocks:
> + maxItems: 1
> + clock-names:
> + items:
> + - const: mfc
> + iommus: false

That's odd. How so? MFC v12 does not support IOMMU?

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-10-25 15:01    [W:0.131 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site