Messages in this thread | | | Date | Wed, 25 Oct 2023 12:54:44 +0000 | From | Simon Ser <> | Subject | Re: [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort |
| |
On Wednesday, October 25th, 2023 at 14:45, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote:
> On 25/10/2023 15:29, Simon Ser wrote: > > > On Wednesday, October 25th, 2023 at 14:22, Johan Hovold johan@kernel.org wrote: > > > > > I was just going to post a patch fixing this after finally investigating > > > why the DisplayPort outputs on the X13s were annoyingly identified as > > > "Unknown20-1" and "Unknown20-2" instead of the expected "DP-1" and > > > "DP-2". > > > > Note, ideally userspace should use drmModeGetConnectorTypeName() from > > libdrm to figure out the proper name for a connector type. That way we > > only need to update a single spot when adding a new connector type, > > instead of patching a whole bunch of programs. > > X11 does its own thing. It further "renames" DP MST connectors. So on my > laptop I end up with DP-1-1 in xrandr, but DP-3 in kernel.
Right. But that function only takes in a connector type enum as input, and returns a string for the type only. It doesn't include the suffix with the number.
IOW: xserver could use drmModeGetConnectorTypeName() and then append "-2" or "-1-1" or whatever.
But with the current appetite for xserver development this is probably not going to happen (and doesn't matter very much).
| |