Messages in this thread | | | Date | Wed, 25 Oct 2023 09:26:29 +0300 | Subject | Re: [PATCH v2 iproute2-next 2/3] rdma: Add an option to set privileged QKEY parameter | From | Patrisious Haddad <> |
| |
On 10/24/2023 8:02 PM, David Ahern wrote: > External email: Use caution opening links or attachments > > > On 10/23/23 5:22 AM, Patrisious Haddad wrote: >> diff --git a/rdma/sys.c b/rdma/sys.c >> index fd785b25..db34cb41 100644 >> --- a/rdma/sys.c >> +++ b/rdma/sys.c >> @@ -40,6 +40,17 @@ static int sys_show_parse_cb(const struct nlmsghdr *nlh, void *data) >> mode_str); >> } >> >> + if (tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]) { >> + uint8_t pqkey_mode; >> + >> + pqkey_mode = >> + mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]); > just make it mode so it fits on one line. will do. > > 40 characters for an attribute name .... I will never understand this > fascination with writing a sentence for an attribute name. me neither, just following the naming convention in rdma/include/uapi/rdma/rdma_netlink.h sadly ... > >> + >> + print_color_on_off(PRINT_ANY, COLOR_NONE, "privileged-qkey", >> + "privileged-qkey %s ", pqkey_mode); >> + >> + } >> + >> if (tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK]) >> cof = mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK]); >> > keep Petr's reviewed-by tag on the respin. will do, just making sure I understand "the respin" , you mean when I re-send it ?
| |