Messages in this thread | | | Date | Wed, 25 Oct 2023 11:41:03 +0100 | Subject | Re: [PATCH 1/4] media: qcom: camss: Convert to per-VFE pointer for power-domain linkages | From | Bryan O'Donoghue <> |
| |
On 25/10/2023 10:16, Konrad Dybcio wrote: >> @@ -653,11 +653,11 @@ static int vfe_pm_domain_on(struct vfe_device *vfe) >> if (id >= camss->res->vfe_num) >> return 0; >> - camss->genpd_link[id] = device_link_add(camss->dev, >> camss->genpd[id], >> - DL_FLAG_STATELESS | >> - DL_FLAG_PM_RUNTIME | >> - DL_FLAG_RPM_ACTIVE); > Good opportunity to inilne vfe->id and get rid of a local var!
Yeah no objection to that, this is a progressive patchset so the index goes away in 1 or 2 patches later in the series anyway.
--- bod
| |