Messages in this thread | | | From | Jason-JH Lin (林睿祥) <> | Subject | Re: [PATCH v2 1/9] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id | Date | Wed, 25 Oct 2023 07:36:07 +0000 |
| |
On Wed, 2023-10-25 at 09:03 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 25/10/2023 08:26, Jason-JH Lin (林睿祥) wrote: > > Hi Krzysztof, > > > > Thanks for the reviews. > > > > On Mon, 2023-10-23 at 09:47 +0200, Krzysztof Kozlowski wrote: > >> > >> External email : Please do not click links or open attachments > until > >> you have verified the sender or the content. > >> On 23/10/2023 06:37, Jason-JH.Lin wrote: > >>> CMDQ_SYNC_TOKEN_SECURE_THR_EOF is used as secure irq to notify > CMDQ > >>> driver in the normal world that GCE secure thread has completed a > >> task > >>> in thee secure world. > >> > >> s/thee/the/ > >> > >>> > >>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > >>> --- > >> > >> This is a new patch, so you must mention it in the changelog. > There > >> is > >> nothing in the changelog saying about this new patch. > >> > >> > >>> include/dt-bindings/gce/mt8195-gce.h | 6 ++++++ > >>> 1 file changed, 6 insertions(+) > >>> > >>> diff --git a/include/dt-bindings/gce/mt8195-gce.h b/include/dt- > >> bindings/gce/mt8195-gce.h > >>> index dcfb302b8a5b..9f99da3363b9 100644 > >>> --- a/include/dt-bindings/gce/mt8195-gce.h > >>> +++ b/include/dt-bindings/gce/mt8195-gce.h > >>> @@ -809,4 +809,10 @@ > >>> /* end of hw event */ > >>> #define CMDQ_MAX_HW_EVENT1019 > >>> > >>> +/* > >>> + * Notify normal CMDQ there are some secure task done, > >>> + * this token sync with secure world. > >>> + */ > >>> +#define CMDQ_SYNC_TOKEN_SECURE_THR_EOF980 > >> > >> Why is this below 1019? Your driver calls it also even, so is this > an > >> event or not? > >> > >> Your driver does not use this value, so does it mean FW uses it? > > > > I just want to separate this kind of event (sw token) from the HW > > event. So I define it after CMDQ_MAX_HW_EVENT. > > SW event? Then why is it in the bindings? >
Sorry, I didn't explain it clearly.
There are 2 kind of GCE event signal: - The SW token means: a GCE HW event signal triggered by SW drivers. e.g. SW driver append a GCE cmd to set a GCE HW event after a specific GCE cmd. Or SW driver use CPU to write a event id to GCE register to trigger the GCE HW event corresponding to that event id.
- The HW event means: a GCE HW event signal triggered by HW engines. e.g. When HW OVL fetches all the data in frame buffer, HW OVL will send a frame done irq and a frame done GCE HW event(via HW bus directly) in the same time.
Regards, Jason-JH.Lin
> Best regards, > Krzysztof > >
| |