Messages in this thread | | | Date | Wed, 25 Oct 2023 09:58:19 +0200 | Subject | Re: [DMARC error] Re: [PATCH v2 03/11] dt-bindings: leds: aw200xx: introduce optional hwen-gpios property | From | Krzysztof Kozlowski <> |
| |
On 24/10/2023 20:52, Dmitry Rokosov wrote: > On Tue, Oct 24, 2023 at 01:30:14PM -0500, Rob Herring wrote: >> On Wed, Oct 18, 2023 at 09:29:35PM +0300, Dmitry Rokosov wrote: >>> Property 'hwen-gpios' is optional, it can be used by the board >>> developer to connect AW200XX LED controller with appropriate poweron >>> GPIO pad. >>> >>> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> >>> --- >>> Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml >>> index feb5febaf361..255eb0563737 100644 >>> --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml >>> +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml >>> @@ -41,6 +41,9 @@ properties: >>> description: >>> Leds matrix size >>> >>> + hwen-gpios: >>> + maxItems: 1 >> >> The standard enable-gpios or powerdown-gpios don't work for you? > > HWEN is the name from the official datasheet. I thought it's always > better to use a naming convention that is similar to the notations used > in the datasheet.
I think we have such rule only for supplies, otherwise you will have multiple variants of the same reset/enable/powerdown-gpios.
Best regards, Krzysztof
| |