Messages in this thread | | | Date | Tue, 24 Oct 2023 16:18:50 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH] arm64: dts: cn913x: add device trees for COM Express boards |
| |
> +&cp0_mdio { > + status = "okay"; > + pinctrl-0 = <&cp0_ge_mdio_pins>; > + phy0: ethernet-phy@0 { > + marvell,reg-init = <3 16 0 0x1a4a>;
What does this do? I guess it is something to do with LEDs. Polarity?
> +&cp0_mdio { > + status = "okay"; > + pinctrl-0 = <&cp0_ge_mdio_pins>; > + phy0: ethernet-phy@0 { > + marvell,reg-init = <3 16 0 0x1a4a>;
I'm temped to NACK this, and get you to work on the LED code in the Marvell PHY driver and phylib to support what you need. This API is horrible and should not be used any more.
Andrew
| |