Messages in this thread | | | Date | Tue, 24 Oct 2023 14:49:20 +0200 | Subject | Re: [PATCH 1/2] i40e: Do not call devlink_port_type_clear() | From | Ivan Vecera <> |
| |
On 24. 10. 23 14:42, Ivan Vecera wrote: > Do not call devlink_port_type_clear() prior devlink port unregister > and let devlink core to take care about it. > > Reproducer: > [root@host ~]# rmmod i40e > [ 4539.964699] i40e 0000:02:00.0: devlink port type for port 0 cleared without a software interface reference, device type not supported by the kernel? > [ 4540.319811] i40e 0000:02:00.1: devlink port type for port 1 cleared without a software interface reference, device type not supported by the kernel? > > Fixes: 9e479d64dc58 ("i40e: Add initial devlink support") > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > --- > drivers/net/ethernet/intel/i40e/i40e_devlink.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_devlink.c b/drivers/net/ethernet/intel/i40e/i40e_devlink.c > index 74bc111b4849..cc4e9e2addb7 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_devlink.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_devlink.c > @@ -231,6 +231,5 @@ int i40e_devlink_create_port(struct i40e_pf *pf) > **/ > void i40e_devlink_destroy_port(struct i40e_pf *pf) > { > - devlink_port_type_clear(&pf->devlink_port); > devlink_port_unregister(&pf->devlink_port); > }
Please drop... there is missing net-next target. Will post v2.
Ivan
| |