lkml.org 
[lkml]   [2023]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 net-next 1/3] ipv6: drop feature RTAX_FEATURE_ALLFRAG
On Tue, Oct 24, 2023 at 12:22 PM Florian Westphal <fw@strlen.de> wrote:
>
> Yan Zhai <yan@cloudflare.com> wrote:
> > #define IPCORK_OPT 1 /* ip-options has been held in ipcork.opt */
> > -#define IPCORK_ALLFRAG 2 /* always fragment (for ipv6 for now) */
> > +#define IPCORK_ALLFRAG 2 /* (unused) always fragment (for ipv6 for now) */
>
> Nit: Why not remove the ALLFRAG define as well?

I agree, this is not exposed to user space and should be deleted.

Reviewed-by: Eric Dumazet <edumazet@google.com>

>
> Otherwise the series looks good to me, thanks!
>
> Reviewed-by: Florian Westphal <fw@strlen.de>
>

\
 
 \ /
  Last update: 2023-10-24 12:32    [W:0.067 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site