Messages in this thread Patch in this message | | | Date | Tue, 24 Oct 2023 08:52:44 -0000 | From | "tip-bot2 for Will Deacon" <> | Subject | [tip: objtool/core] scripts/faddr2line: Don't filter out non-function symbols from readelf |
| |
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: 180af1a5bdaf8d4964837a46a9fce8c3a7fd2d97 Gitweb: https://git.kernel.org/tip/180af1a5bdaf8d4964837a46a9fce8c3a7fd2d97 Author: Will Deacon <will@kernel.org> AuthorDate: Mon, 02 Oct 2023 17:57:47 +01:00 Committer: Josh Poimboeuf <jpoimboe@kernel.org> CommitterDate: Mon, 23 Oct 2023 08:35:01 -07:00
scripts/faddr2line: Don't filter out non-function symbols from readelf
As Josh points out in 20230724234734.zy67gm674vl3p3wv@treble:
> Problem is, I think the kernel's symbol printing code prints the > nearest kallsyms symbol, and there are some valid non-FUNC code > symbols. For example, syscall_return_via_sysret.
so we shouldn't be considering only 'FUNC'-type symbols in the output from readelf.
Drop the function symbol type filtering from the faddr2line outer loop.
Suggested-by: Josh Poimboeuf <jpoimboe@kernel.org> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Link: https://lore.kernel.org/r/20230724234734.zy67gm674vl3p3wv@treble Signed-off-by: Will Deacon <will@kernel.org> Link: https://lore.kernel.org/r/20231002165750.1661-2-will@kernel.org Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> --- scripts/faddr2line | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/faddr2line b/scripts/faddr2line index 0e73aca..a35a420 100755 --- a/scripts/faddr2line +++ b/scripts/faddr2line @@ -260,7 +260,7 @@ __faddr2line() { DONE=1 - done < <(${READELF} --symbols --wide $objfile | sed 's/\[.*\]//' | ${AWK} -v fn=$sym_name '$4 == "FUNC" && $8 == fn') + done < <(${READELF} --symbols --wide $objfile | sed 's/\[.*\]//' | ${AWK} -v fn=$sym_name '$8 == fn') } [[ $# -lt 2 ]] && usage
| |