Messages in this thread | | | From | Jason-JH Lin (林睿祥) <> | Subject | Re: [PATCH v2 5/9] soc: mailbox: Add cmdq_pkt_finalize_loop to support looping cmd with irq | Date | Wed, 25 Oct 2023 00:55:45 +0000 |
| |
On Mon, 2023-10-23 at 11:50 +0200, AngeloGioacchino Del Regno wrote: > Il 23/10/23 06:37, Jason-JH.Lin ha scritto: > > Add cmdq_pkt_finalize_loop to CMDQ driver. > > > > cmdq_pkt_finalize_loop appends end of command(EOC) instruction and > > jump to start of command buffer instruction to make the command > > buffer loopable. > > > > GCE irq occurs when GCE executes to the EOC instruction. > > CMDQ client can use a loop flag to mark the CMDQ packet as looping > > packet. If the CMDQ packet is a loopping packet, GCE irq handler > > won't delete the CMDQ task and disable the GCE thread. > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > --- > > drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++++++++++ > > drivers/soc/mediatek/mtk-cmdq-helper.c | 23 > > +++++++++++++++++++++++ > > include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + > > include/linux/soc/mediatek/mtk-cmdq.h | 8 ++++++++ > > 4 files changed, 43 insertions(+) > > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > > b/drivers/mailbox/mtk-cmdq-mailbox.c > > index 4d62b07c1411..56fe01cd9731 100644 > > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > > It's true that without the changes in soc/mediatek this is not doing > anything, but > mailbox/mtk-cmdq-mailbox.c goes through a different maintainer... > > Please split the changes to drivers/mailbox/mtk-cmdq-mailbox.c and > its header to a > different commit. > > Hint: > 1. soc: mediatek: cmdq: Add cmdq_pkt_finalize_loop for looping cmd > with irq > 2. mailbox: mtk-cmdq: Support GCE loop packets in interrupt handler >
That's what I have done in the previous version. Because of Krzysztof's comment here: https://patchwork.kernel.org/project/linux-mediatek/patch/20230918192204.32263-8-jason-jh.lin@mediatek.com/#25527450 I squash them together. I'm not sure if I misunderstood that.
But I think I should follow the maintainer who can apply the patch. So I'll split it in the next version.
Regards, Jason-JH.Lin
> Thanks, > Angelo >
| |