Messages in this thread | | | Date | Wed, 25 Oct 2023 08:23:45 +0800 | From | Tzung-Bi Shih <> | Subject | Re: [PATCH v3] platform/chrome: cros_ec_lpc: Separate host command and irq disable |
| |
On Tue, Oct 24, 2023 at 10:58:21AM -0500, Lalith Rajendran wrote: > +/** > + * cros_ec_suspend_prepare() - Handle a suspend prepare operation for the ChromeOS EC device. > + * @ec_dev: Device to suspend. > + * > + * This can be called by drivers to handle a suspend prepare stage of suspend. > + * > + * Return: 0 on success or negative error code.
Please update accordingly to reflect the fact.
> +/** > + * cros_ec_suspend_late() - Handle a suspend late operation for the ChromeOS EC device. > + * @ec_dev: Device to suspend. > + * > + * This can be called by drivers to handle a suspend late stage of suspend. > + * > + * Return: 0 on success or negative error code.
Ditto.
> + */ > +int cros_ec_suspend_late(struct cros_ec_device *ec_dev) > +{ > + cros_ec_disable_irq(ec_dev); > + return 0; > +} > +EXPORT_SYMBOL(cros_ec_suspend_late); > > +/** > + * cros_ec_suspend() - Handle a suspend operation for the ChromeOS EC device. > + * @ec_dev: Device to suspend. > + * > + * This can be called by drivers to handle a suspend event. > + * > + * Return: 0 on success or negative error code.
Ditto.
> +/** > + * cros_ec_resume_early() - Handle a resume early operation for the ChromeOS EC device. > + * @ec_dev: Device to resume. > + * > + * This can be called by drivers to handle a resume early stage of resume. > + * > + * Return: 0 on success or negative error code.
Ditto.
> + */ > +int cros_ec_resume_early(struct cros_ec_device *ec_dev) > +{ > + cros_ec_enable_irq(ec_dev); > + return 0; > +} > +EXPORT_SYMBOL(cros_ec_resume_early); > > +/** > + * cros_ec_resume() - Handle a resume operation for the ChromeOS EC device. > + * @ec_dev: Device to resume. > + * > + * This can be called by drivers to handle a resume event. > + * > + * Return: 0 on success or negative error code.
Ditto.
| |