Messages in this thread | | | Date | Tue, 24 Oct 2023 13:01:51 -0700 | Subject | Re: [PATCH] scsi: fcoe: replace deprecated strncpy with strscpy | From | Bart Van Assche <> |
| |
On 10/24/23 12:52, Justin Stitt wrote: > diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c b/drivers/scsi/fcoe/fcoe_sysfs.c > index e17957f8085c..7a3ca6cd3030 100644 > --- a/drivers/scsi/fcoe/fcoe_sysfs.c > +++ b/drivers/scsi/fcoe/fcoe_sysfs.c > @@ -279,12 +279,10 @@ static ssize_t store_ctlr_mode(struct device *dev, > if (count > FCOE_MAX_MODENAME_LEN) > return -EINVAL; > > - strncpy(mode, buf, count); > + strscpy(mode, buf, count); > > if (mode[count - 1] == '\n') > mode[count - 1] = '\0'; > - else > - mode[count] = '\0'; > > switch (ctlr->enabled) { > case FCOE_CTLR_ENABLED:
Please consider to remove the code for copying the sysfs string and to use sysfs_match_string() instead.
Thanks,
Bart.
| |