Messages in this thread | | | Date | Tue, 24 Oct 2023 21:18:01 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH v3 2/2] i2c: mv64xxx: add an optional reset-gpios property |
| |
Hi Chris,
as you are working on the v4...
...
> + if (drv_data->reset_gpio) { > + usleep_range(reset_duration, reset_duration + 10);
I'm not against this, but it's not optimal unless we know more or less what to expect from reset_duration.
Do we have a rough idea of what reset_duration is? If we don't then you could consider using a generic "fsleep(reset_duration);" Would it work?
Rest looks good.
Andi
| |