lkml.org 
[lkml]   [2023]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 2/5] net: dsa: qca: Make the QCA8K hardware library available globally
> @@ -62,21 +61,37 @@ const struct qca8k_mib_desc ar8327_mib[] = {
> MIB_DESC(1, 0xa8, "RXUnicast"),
> MIB_DESC(1, 0xac, "TXUnicast"),
> };
> +EXPORT_SYMBOL(ar8327_mib);

Christian should decide, since he wrote most of this code, but i would
prefer EXPORT_SYMBOL_GPL().

> --- a/drivers/net/dsa/qca/qca8k.h
> +++ b/include/linux/dsa/qca8k.h
> @@ -13,6 +13,7 @@
> #include <linux/gpio.h>
> #include <linux/leds.h>
> #include <linux/dsa/tag_qca.h>
> +#include <net/dsa.h>
>
> #define QCA8K_ETHERNET_MDIO_PRIORITY 7
> #define QCA8K_ETHERNET_PHY_PRIORITY 6
> @@ -265,6 +266,7 @@
> #define QCA8K_PORT_LOOKUP_STATE_LEARNING QCA8K_PORT_LOOKUP_STATE(0x3)
> #define QCA8K_PORT_LOOKUP_STATE_FORWARD QCA8K_PORT_LOOKUP_STATE(0x4)
> #define QCA8K_PORT_LOOKUP_LEARN BIT(20)
> +#define QCA8K_PORT_LOOKUP_LOOPBACK_EN BIT(21)

Maybe do the move first, and then add new features in another patch?

Andrew

\
 
 \ /
  Last update: 2023-10-23 18:41    [W:0.179 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site