Messages in this thread | | | Date | Mon, 23 Oct 2023 09:15:11 -0700 | From | Luis Chamberlain <> | Subject | Re: [PATCH v3] firmware_loader: Abort new fw load request once firmware core knows about reboot |
| |
On Mon, Oct 23, 2023 at 06:11:18PM +0530, Mukesh Ojha wrote: > However, if you think we should rename this > 'only_kill_custom' to something like its inverse 'kill_all' and reverse the > below check to be more meaningful now ? > > if (kill_all || !fw_priv->need_uevent)
This seems like a better approach to make the intent clear and avoid future confusion.
Luis
| |