lkml.org 
[lkml]   [2023]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH v2] iio: imu: inv_mpu6050: fix an error code problem in inv_mpu6050_read_raw
    Date
    Hello,

    looks good for me, thanks for the fix.

    Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>

    Thanks,
    JB

    From: Su Hui <suhui@nfschina.com>
    Sent: Monday, October 23, 2023 06:05
    To: Jonathan.Cameron@Huawei.com <Jonathan.Cameron@Huawei.com>; jic23@kernel.org <jic23@kernel.org>; lars@metafoo.de <lars@metafoo.de>
    Cc: Su Hui <suhui@nfschina.com>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; andy.shevchenko@gmail.com <andy.shevchenko@gmail.com>; chenhuiz@axis.com <chenhuiz@axis.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>
    Subject: [PATCH v2] iio: imu: inv_mpu6050: fix an error code problem in inv_mpu6050_read_raw
     
    inv_mpu6050_sensor_show() can return -EINVAL or IIO_VAL_INT. Return the true value rather than only return IIO_VAL_INT. Signed-off-by: Su Hui <suhui@ nfschina. com> --- v2: - fix the error of commit title. v1: - https: //urldefense. com/v3/__https: //lore. kernel. org/all/20231020091413. 205743-2-suhui@ nfschina. com/__;!!FtrhtPsWDhZ6tw!HkhoYyOc-Whx_ROmsl5laocdgPfmACC5Piff96FG_nwTqZFA4GgXeNhp7q1wVElUFbfabAcCmt6D1uuKA1LO1q5E$[lore[. ]kernel[. ]org]
    ZjQcmQRYFpfptBannerStart
    This Message Is From an Untrusted Sender
    You have not previously corresponded with this sender.
     
    ZjQcmQRYFpfptBannerEnd
    inv_mpu6050_sensor_show() can return -EINVAL or IIO_VAL_INT. Return the
    true value rather than only return IIO_VAL_INT.

    Signed-off-by: Su Hui <suhui@nfschina.com>
    ---
    v2:
    - fix the error of commit title.
    v1:
    - https://urldefense.com/v3/__https://lore.kernel.org/all/20231020091413.205743-2-suhui@nfschina.com/__;!!FtrhtPsWDhZ6tw!HkhoYyOc-Whx_ROmsl5laocdgPfmACC5Piff96FG_nwTqZFA4GgXeNhp7q1wVElUFbfabAcCmt6D1uuKA1LO1q5E$[lore[.]kernel[.]org]
    drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
    index 29f906c884bd..a9a5fb266ef1 100644
    --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
    +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
    @@ -749,13 +749,13 @@ inv_mpu6050_read_raw(struct iio_dev *indio_dev,
    ret = inv_mpu6050_sensor_show(st, st->reg->gyro_offset,
    chan->channel2, val);
    mutex_unlock(&st->lock);
    - return IIO_VAL_INT;
    + return ret;
    case IIO_ACCEL:
    mutex_lock(&st->lock);
    ret = inv_mpu6050_sensor_show(st, st->reg->accl_offset,
    chan->channel2, val);
    mutex_unlock(&st->lock);
    - return IIO_VAL_INT;
    + return ret;

    default:
    return -EINVAL;
    --
    2.30.2
    \
     
     \ /
      Last update: 2023-10-23 15:30    [W:6.964 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site