Messages in this thread | | | Date | Mon, 23 Oct 2023 15:20:13 +0200 | Subject | Re: [PATCH] arm64: dts: freescale: debix-som: Add heartbeat LED | From | Krzysztof Kozlowski <> |
| |
On 21/10/2023 02:50, Kieran Bingham wrote: > Map the 'RUN' LED present on the Debix-SOM as a heartbeat. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > .../dts/freescale/imx8mp-debix-som-a.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi > index bc312aa1bfc8..c9a81486da48 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi > @@ -20,6 +20,19 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > + > + gpio-leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpio_led>; > + > + status {
Missing led prefix. I think I fixed it everywhere some time ago, so I wonder from where did you copy it. :/
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions).
> + label = "yellow:status";
Drop label. Use color and function.
Best regards, Krzysztof
| |