Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 23 Oct 2023 15:02:02 +0300 | Subject | Re: [PATCH 1/2] x86/xen/pvh: Set up percpu for stack canary in 32-bit kernel entry |
| |
On Mon, Oct 23, 2023 at 12:10 PM Hou Wenlong <houwenlong.hwl@antgroup.com> wrote: > > In a 32-bit SMP kernel, the stack canary is a percpu variable accessed > as %fs:__stack_chk_guard. However, the ABI for PVH entry does not > specify the %fs register state. It currently works because the initial > %fs register is 0x10 for QEMU, which is the same as $PVH_DS_SEL.
> %However, for added safety, the percpu should be set up explicitly > %before calling xen_prepare_pvh(), which accesses the stack canary.
Stray leading % in two lines above.
-- With Best Regards, Andy Shevchenko
| |