Messages in this thread | | | Date | Mon, 23 Oct 2023 12:27:56 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS |
| |
On Fri, Oct 20, 2023, at 15:35, Jerome Brunet wrote: > On Fri 20 Oct 2023 at 15:19, Arnd Bergmann <arnd@kernel.org> wrote: > >> From: Arnd Bergmann <arnd@arndb.de> >> >> Without this, the newly added driver fails to link: >> >> aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe': >> s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get' >> >> Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> --- >> drivers/clk/meson/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig >> index c5303e4c16043..3c28560b0faba 100644 >> --- a/drivers/clk/meson/Kconfig >> +++ b/drivers/clk/meson/Kconfig >> @@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL >> tristate "S4 SoC PLL clock controllers support" >> depends on ARM64 >> default y >> + select COMMON_CLK_MESON_CLKC_UTILS >> select COMMON_CLK_MESON_MPLL >> select COMMON_CLK_MESON_PLL >> select COMMON_CLK_MESON_REGMAP > > Thx Arnd and sorry about this. > > Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> > > Stephen, do you mind taking this directly ?
I ran into the same bug with drivers/clk/meson/s4-peripherals.c, sending a v2 of my patch to fix both at the same time, assuming v1 has not been applied yet (it's not in today's linux-next).
Arnd
| |