Messages in this thread | | | From | Fei Shao <> | Date | Mon, 23 Oct 2023 17:14:05 +0800 | Subject | Re: [PATCH v2 3/9] soc: mailbox: Add cmdq_pkt_logic_command to support math operation |
| |
On Mon, Oct 23, 2023 at 4:26 PM Fei Shao <fshao@chromium.org> wrote: > > Hi Jason, > > On Mon, Oct 23, 2023 at 12:39 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote: <snip>
> > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > > index a253c001c861..ea4fadfb5443 100644 > > --- a/include/linux/soc/mediatek/mtk-cmdq.h > > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > > @@ -26,6 +26,30 @@ > > > > struct cmdq_pkt; > > > > +enum CMDQ_LOGIC_ENUM { > Use lower case, and perhaps use `cmdq_logic_type` or `cmdq_operator_type`. I overlooked the CMDQ_CODE_LOGIC line, so cmdq_logic_type makes more sense.
Regards, Fei
| |