lkml.org 
[lkml]   [2023]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] ASoC: mediatek: mt7986: remove redundant remove function
Date
On Mon, 2023-10-23 at 13:07 +0200, AngeloGioacchino Del Regno wrote:
> Il 23/10/23 11:54, Maso Huang ha scritto:
> > Remove redundant remove function of mt7986-wm8960.
> >
> > Signed-off-by: Maso Huang <maso.huang@mediatek.com>
>
> You're doing more than what you're advertising; you are:
>
> 1. Dropping the remove callback; and
> 2. Removing the mt7986_wm8960_priv structure
>
> You can do that in one single commit if you really want to, but you
> have to
> use the appropriate commit title and description, saying exactly what
> you're doing.
>
> Regards,
> Angelo
>

Hi Angelo,

Thanks for your review!
I'll devide into two with appropriate title and description in v2.

Best regards,
Maso
\
 
 \ /
  Last update: 2023-10-24 04:30    [W:0.103 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site