Messages in this thread | | | Date | Mon, 23 Oct 2023 21:56:16 +0200 | Subject | Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs | From | Konrad Dybcio <> |
| |
On 10/23/23 21:42, Rob Clark wrote: > On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> New GPUs still use the lower 2 bytes of the chip id (in whatever form >> it comes) to signify silicon revision. Drop the warning that makes it >> sound as if that was unintended. >> >> Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GPU") >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h >> index 80b3f6312116..9a1ec42155fd 100644 >> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h >> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h >> @@ -203,11 +203,6 @@ struct adreno_platform_config { >> >> static inline uint8_t adreno_patchid(const struct adreno_gpu *gpu) >> { >> - /* It is probably ok to assume legacy "adreno_rev" format >> - * for all a6xx devices, but probably best to limit this >> - * to older things. >> - */ >> - WARN_ON_ONCE(gpu->info->family >= ADRENO_6XX_GEN1); > > Maybe just change it to ADRENO_6XX_GEN4? That also applies to 700
Konrad
| |