Messages in this thread | | | Date | Mon, 23 Oct 2023 23:12:40 +0530 | Subject | Re: [PATCH v13 09/10] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports | From | Krishna Kurapati PSSNV <> |
| |
On 10/23/2023 9:53 PM, Johan Hovold wrote: > On Sat, Oct 07, 2023 at 09:18:05PM +0530, Krishna Kurapati wrote: >> Enable tertiary controller for SA8295P (based on SC8280XP). >> Add pinctrl support for usb ports to provide VBUS to connected peripherals. >> >> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 49 ++++++++++++++++++++++++ >> 1 file changed, 49 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts >> index fd253942e5e5..271000163823 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts >> +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts >> @@ -9,6 +9,7 @@ >> #include <dt-bindings/gpio/gpio.h> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> #include <dt-bindings/spmi/spmi.h> >> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > > Sort order ('p' < 'r').
ACK
> >> +&usb_2 { >> + pinctrl-0 = <&usb2_en_state>, >> + <&usb3_en_state>, >> + <&usb4_en_state>, >> + <&usb5_en_state>; >> + pinctrl-names = "default"; >> + >> + status = "okay"; >> +}; >> + >> &usb_2_hsphy0 { >> vdda-pll-supply = <&vreg_l5a>; >> vdda18-supply = <&vreg_l7g>; >> @@ -729,3 +740,41 @@ wake-n-pins { >> }; >> }; >> }; >> + >> +&pmm8540c_gpios { > > Sort order here too ('p' < 't' in "&tlmm"). >
ACK.
>> + usb2_en_state: usb2-en-state { > > No need to include '_state' in the labels. > Any specific reason ? I have no problem if removing the suffix but just wanted to know the reason.
Regards, Krishna,
| |