lkml.org 
[lkml]   [2023]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"
On Sun, Oct 22, 2023 at 3:17 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:
> > Every DT property needs a type defined, but "i2c-alias" is missing any
> > type definition. It's a "uint32", so add a type reference.
> >
> > Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> This is something I should have paid more attention when reviewing the
> bindings. I'll try to keep it in mind for the future.

No need, the tools will check for you now. :)

But the same property defined multiple times is not yet checked

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks.

Rob

\
 
 \ /
  Last update: 2023-10-22 23:00    [W:0.829 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site