Messages in this thread | | | Date | Sun, 22 Oct 2023 08:38:51 +0200 | Subject | Re: [PATCH v3] staging: rtl8192e: renamed variable TxCountToDataRate | From | Philipp Hortmann <> |
| |
On 10/21/23 23:54, Gary Rookard wrote: > Renamed from Pascal/CamelCase to Snake case the variable > TxCountDataRate, TxCountDataRate -> tx_count_data_rate. > > Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. > Driver rtl8192e compiles. > > Signed-off-by: Gary Rookard <garyrookard@fastmail.org> > --- > Removed parenthesis alignment, and removed corrected spacing from > this patch. Only contains renaming variable. > > drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- > drivers/staging/rtl8192e/rtllib.h | 2 +- > drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c > index 00b21542ddc3..8070a152712e 100644 > --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c > +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c > @@ -114,7 +114,7 @@ static u16 HTMcsToDataRate(struct rtllib_device *ieee, u8 nMcsRate) > return MCS_DATA_RATE[is40MHz][isShortGI][(nMcsRate & 0x7f)]; > } > > -u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate) > +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
tx_count_to_data_rate
> { > u16 CCKOFDMRate[12] = {0x02, 0x04, 0x0b, 0x16, 0x0c, 0x12, 0x18, > 0x24, 0x30, 0x48, 0x60, 0x6c}; > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > index 9d141aad8cd5..6a9550eaf148 100644 > --- a/drivers/staging/rtl8192e/rtllib.h > +++ b/drivers/staging/rtl8192e/rtllib.h > @@ -1784,7 +1784,7 @@ extern u16 MCS_DATA_RATE[2][2][77]; > u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame); > void HTResetIOTSetting(struct rt_hi_throughput *ht_info); > bool IsHTHalfNmodeAPs(struct rtllib_device *ieee); > -u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate); > +u16 tx_count_data_rate(struct rtllib_device *ieee, u8 nDataRate);
tx_count_data_rate
> int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb); > int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb); > int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb); > diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c > index f32584291704..28aba1d610f7 100644 > --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c > +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c > @@ -208,7 +208,7 @@ int rtllib_wx_get_rate(struct rtllib_device *ieee, > { > u32 tmp_rate; > > - tmp_rate = TxCountToDataRate(ieee, > + tmp_rate = tx_count_to_data_rate(ieee,
tx_count_to_data_rate
> ieee->softmac_stats.CurrentShowTxate); > wrqu->bitrate.value = tmp_rate * 500000; >
Hi,
name of the function are different.
You need to do a compile testing before sending in.
drivers/staging/rtl8192e/rtllib_softmac_wx.c: In function ‘rtllib_wx_get_rate’: drivers/staging/rtl8192e/rtllib_softmac_wx.c:211:13: error: implicit declaration of function ‘tx_count_to_data_rate’; did you mean ‘tx_count_data_rate’? [-Werror=implicit-function-declaration] 211 | tmp_rate = tx_count_to_data_rate(ieee, | ^~~~~~~~~~~~~~~~~~~~~ | tx_count_data_rate cc1: some warnings being treated as errors
Bye Philipp
| |