lkml.org 
[lkml]   [2023]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: rtl8192e: renamed varaible HTIOTActIsDisableMCS15
From
On 10/22/23 01:53, Gary Rookard wrote:
> Renamed from Pascal/CamelCase to Snake case the variable
> HTIOCActIsDisableMCS15, HTIOTActIsDisableMCS15 -> ht_ioc_act_disable_mcs15.
>
> Linux kernel coding style (cleanup), checkpatch Avoid CamelCase
> Driver rtl8192e compiles.
>
> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
> ---
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 5dca97b07874..8868672131a1 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -212,7 +212,7 @@ static u8 ht_iot_act_is_disable_mcs14(struct rtllib_device *ieee, u8 *PeerMacAdd
> return 0;
> }
>
> -static bool HTIOTActIsDisableMCS15(struct rtllib_device *ieee)
> +static bool ht_iot_act_is_disable_mcs15(struct rtllib_device *ieee)
> {
> return false;
> }
> @@ -700,7 +700,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
> if (bIOTAction)
> ht_info->iot_action |= HT_IOT_ACT_DISABLE_MCS14;
>
> - bIOTAction = HTIOTActIsDisableMCS15(ieee);
> + bIOTAction = ht_iot_act_is_disable_mcs15(ieee);
> if (bIOTAction)
> ht_info->iot_action |= HT_IOT_ACT_DISABLE_MCS15;
>

Hi,

please use checkpatch on your patches.

WARNING: 'varaible' may be misspelled - perhaps 'variable'?
#4:
Subject: [PATCH] staging: rtl8192e: renamed varaible HTIOTActIsDisableMCS15
^^^^^^^^

Bye Philipp

\
 
 \ /
  Last update: 2023-10-22 08:34    [W:0.045 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site